ERROR_MSG_LENGTH is 4096, my query is larger than that.> What's the rationale here and how do we fix it? This works fine with
old driver.
That code is fishy. I should be making strncpy, not strcpy, and I don't understand why ERROR_MSG_LENGTH is used for the length. The query is copied again (with strdup) inside QR_set_command.
IMO, it doesn't seem worthwhile to make the extra copy just to be able to trim spaces leter.
Merlin
---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
-----Original Message-----> From: pgsql-odbc-owner@postgresql.org > [mailtogsql-odbc-owner@postgresql.org] On Behalf Of Scot Loach> Sent: 02 September 2005 13:12> To: pgsql-odbc@postgresql.org> Subject: [ODBC] crash in LIBPQ_execute_query>
Some of the queries we use can be very large.> My code is crashing here:>
ERROR_MSG_LENGTH is 4096, my query is larger than that.> What's the rationale here and how do we fix it? This works > fine with the old driver.
Urgh. To be honest, I can't see any need to copy that string at all in there, so the limit is entirely unwarranted. In addition, there's code in there marked #ifndef USE_LIBPQ (in LIBPQ_Execute!!), and, it sets the rowcount to -1 if it can't find a space in the SQL query!
I've tidied that up - patch attached. Please let me know how it goes.
Regards, Dave
---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
That seems to work. Thanks for the quick reply Dave.
-----Original Message----- From: Dave Page [mailto:dpage@vale-housing.co.uk] Sent: Friday, September 02, 2005 8:58 AM To: Scot Loach; pgsql-odbc@postgresql.org Cc: Anoop Kumar Subject: RE: [ODBC] crash in LIBPQ_execute_query
-----Original Message-----> From: pgsql-odbc-owner@postgresql.org > [mailtogsql-odbc-owner@postgresql.org] On Behalf Of Scot Loach> Sent: 02 September 2005 13:12> To: pgsql-odbc@postgresql.org> Subject: [ODBC] crash in LIBPQ_execute_query>
Some of the queries we use can be very large.> My code is crashing here:>
ERROR_MSG_LENGTH is 4096, my query is larger than that.> What's the rationale here and how do we fix it? This works > fine with the old driver.
Urgh. To be honest, I can't see any need to copy that string at all in there, so the limit is entirely unwarranted. In addition, there's code in there marked #ifndef USE_LIBPQ (in LIBPQ_Execute!!), and, it sets the rowcount to -1 if it can't find a space in the SQL query!
I've tidied that up - patch attached. Please let me know how it goes.
Regards, Dave
---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to majordomo@postgresql.org so that your message can get through to the mailing list cleanly
ERROR_MSG_LENGTH is 4096, my query is larger than that.> > What's the rationale here and how do we fix it? This works > > fine with the old driver.>
Urgh. To be honest, I can't see any need to copy that string at all in> there, so the limit is entirely unwarranted. In addition, there's code> in there marked #ifndef USE_LIBPQ (in LIBPQ_Execute!!), and, > it sets the> rowcount to -1 if it can't find a space in the SQL query!>
I've tidied that up - patch attached. Please let me know how it goes.>
Regards, Dave>
---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
If you would like to report an abuse of our service, such as a spam message, please . Если Вы хотите пожаловаться на содержимое этой страницы, пожалуйста .
