This patch implements the change that Craig Berry suggested earlier this week, to eliminate duplicate warning messages, and not to throw a warning as a result of a subprocess error exit.
Jarkko Hietaniemi 16 November 2001 23:21:10 [ permanent link ]
On Fri, Nov 16, 2001 at 03:20:11PM -0500, Charles Lane wrote:> This patch implements the change that Craig Berry suggested earlier this> week, to eliminate duplicate warning messages, and not to throw a warning> as a result of a subprocess error exit.
Thanks, applied.
-- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. -- Jack Cohen
Craig A. Berry 17 November 2001 00:51:52 [ permanent link ]
At 3:20 PM -0500 11/16/01, Charles Lane wrote:>This patch implements the change that Craig Berry suggested earlier this>week, to eliminate duplicate warning messages, and not to throw a warning>as a result of a subprocess error exit.
But doesn't this change the behavior of the lib$spawn case? We should return the value of substs (the completion status of the subprocess), it's just that sts (the status of initiating the subprocess) should be checked first (with a warning thrown if necessary). In the safe_popen case, the initiation checking has already been done internally so we don't want to do it again and we can't anyway because all we get back from it is the process completion status. You really don't want to do the checks that were designed for process initiation on the status you get from process completion.
Charles Lane 17 November 2001 01:05:05 [ permanent link ]
Craig Berry writes:> At 3:20 PM -0500 11/16/01, Charles Lane wrote:> >This patch implements the change that Craig Berry suggested earlier this> >week, to eliminate duplicate warning messages, and not to throw a warning> >as a result of a subprocess error exit.
But doesn't this change the behavior of the lib$spawn case? We> should return the value of substs (the completion status of the> subprocess), it's just that sts (the status of initiating the> subprocess) should be checked first (with a warning thrown if> necessary).
Drat.
In the safe_popen case, the initiation checking has> already been done internally so we don't want to do it again and we> can't anyway because all we get back from it is the process> completion status. You really don't want to do the checks that were> designed for process initiation on the status you get from process> completion.
I think you want something like this instead:
(patch elided) Well, the patch I posted put all the "set errno & throw warning" stuff only after the lib$spawn, so I think the testing of sts is doing what you want.
But you're right, the return needs to have substs from lib$spawn, not sts.
Craig A. Berry 17 November 2001 01:28:38 [ permanent link ]
At 5:05 PM -0500 11/16/01, Charles Lane wrote:
(patch elided)>Well, the patch I posted put all the "set errno & throw warning" stuff>only after the lib$spawn, so I think the testing of sts is doing what>you want.
OK.
But you're right, the return needs to have substs from lib$spawn, not>sts.>
Okay, apply on top of the previous patch:
Looks good to me. This should make it functionally equivalent to my alternative patch.
diff -uBb vms/vms.c-orig vms/vms.c>--- vms/vms.c-origFri Nov 16 17:03:26 2001>+++ vms/vms.cFri Nov 16 17:02:53 2001
-- ____________________________________________ Craig A. Berry mailto:craigberry@mac.com
"Literary critics usually know what they're talking about. Even if they're wrong." -- Perl creator Larry Wall
Craig A. Berry 17 November 2001 22:31:55 [ permanent link ]
At 8:57 PM +0200 11/17/01, Jarkko Hietaniemi wrote:>Just checking since the patches I've seen don't quite "add up",>here's vms.cerl_do_spawn as of patch 13036:
This looks right to me (though the indentation is getting a bit unconventional, Chuck). -- ________________________________________ Craig A. Berry mailto:craigberry@mac.com
"... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Jarkko Hietaniemi 18 November 2001 02:17:19 [ permanent link ]
On Sat, Nov 17, 2001 at 01:31:55PM -0600, Craig A. Berry wrote:> At 8:57 PM +0200 11/17/01, Jarkko Hietaniemi wrote:> >Just checking since the patches I've seen don't quite "add up",> >here's vms.cerl_do_spawn as of patch 13036:>
This looks right to me (though the indentation is getting a bit> unconventional, Chuck).
Any objections if I shake GNU indent at vms/vms.c? (I can iterate the options a bit till I get somewhat *minimal* set of changes.)
-- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. -- Jack Cohen
If you would like to report an abuse of our service, such as a spam message, please . Если Вы хотите пожаловаться на содержимое этой страницы, пожалуйста .
![[Patch Perl@13023] VMS system() warning](http://qaix.com/i/logo_new.gif){kind=logo}
