What is "My links" and what are they for?
[PATCH] Apache2::RequestIO::read bugfix + enhancements
Hello Guest		   
  • Login
• Register…
• Start blog		   • Who, Where, When
• What can I do?
• What to Read?		   • Polls
• Avatars
• Interests		   • Cities and Countries
• Random blog
• Users search		   • Search
• Games
• Tests
• QAIX		   • Сообщества
• Talxy Chat
• Horoscope
• Online		  
Зарегистрируйся!
QAIX > Apache HTTP Server > [PATCH] Apache2::RequestIO:­:read bugfix + enhancements 30 July 2008 20:48:14
  Recent blog posts: 
The song my brother thought me
Don't let your heart be hardened Don't let your love grow cold May it always stay so childlike May it…

My brother thought me this…
God grant me the serenity to accept the things I cannot change; courage to change the things I can;…

baz-baz-baz-baz pam-parabaram…
baz-baz-baz-baz pam-parabaram baz-baz-baz-baz pam-parabaram baz-baz-baz-baz pam-parabaram-baz ba-ra-ba…

Blackfriday&Cybermonday…
:-D­ Today is Thanks giving; Blackfriday&Cybermo­­nday is very close to us now. And…

Harvest your surprise on…
Harvest your surprise on Thanksgiving Day – more discount at Nidesoft…

Blackfriday&Cybermonday…
Blackfriday&Cybermon­­day Software special offer lists: Today is Thanks giving;…

BlackBerry Storm VS iPhone 3G…
Recently I had published a side-by-side comparison of the iPhone 3G and T-Mobile G1 which evoked an…

Review on TuneClone Audio…
There is an in-depth review of TuneClone Audio Converter&hellip­;

How to make a Christmas photo…
Every Christmas people take a off from their busy schedule. This is the time they can enjoy with their…

Car web design, motorbike…
If you are looking for Car website design, Auto web design, bike web design, or anything similar our…

  They have birthday today: 
Ray Stewart
  Forums:   
    topic feeds

• QAIX  all topics, blogs and comments

• PHP web-programming

• Perl web-programming

• ASP web-programming

• Visual Basic Programming

• .Net Development

• C/C++ Programming

• Java Programming

• Javascript web-programming

• Apache HTTP Server

• Web-design

• Web-hosting, dedicated, colocation

• HTML web-programming

• XML development

• General Web-programming

• Content Management Systems

• ColdFusion

• Search Engine Optimization

• Hardware

• Software, Computer Help

• MySQL database development

• PostgreSQL database development

• MS Access database development

• Oracle database development

• MS SQL database development

• Informix database development

• Buy / Sell

• Open discussion

• Anonymous
  Discuss: 
PATCH for apache-1.3 when…
Hi all, This afternoon I try to compile my standard bundle (mod_perl 1.30, apache 1.3.41…

Apache::Bootstrap to ASF…
Hi all, I'll be releasing Apache::Bootstrap 0.05 in the next two weeks, 0.04_2 is passing all tests but…

[RELEASE CANDIDATE]…
The mod_perl 1.31 release candidate 4 "Works with Perl 5.10" is ready. It can be downloaded…

[Fwd: Time for 2.2.11?]
…

Premature end of script headers
Hi everybody, When I brwoser this perl script on the web broswer, it gives error: Internal Server Error…
  Recent forum topics: 
Expiration of your subscription…
Thu, 18 Sep 2008 06:00:05 Your subscription to the DOTNET-CLR list has expired and you have failed to…

SQL Server 2005: CLR functions…
I was playing around with the new SQL 2005 CLR functionality and remembered this discussion that I had…

VivaMP for OpenMP
OOO “Program Verification Systems” Company informs you that the first beta-version of static C/C++ code…

Mailing-list
Hi! Thanks for all good information and help I'v got throw all contacts in the mailinglist…
  Recent forum comments:
RE: neopets hacking
All is to do send me your username and password and pin (if you have) to the following email…

RE: DBI w/Multiple mysql installed…
On Wed, 26 Nov 2008 12:36:28 -0700, Anthony DeMatteis <adematteis@commspe­ed.net> wrote…

RE: Files, Directories, Resources…
Can I just remind everyone that (IMO) we shouldn't just be considering filesystems here? I think it…

RE: Re: [perl #60828] [BUG] ^@list…
On Wed, Nov 26, 2008 at 08:54:50AM +0100, Moritz Lenz wrote: : : : Patrick R. Michaud wrote: : >…

RE: Files, Directories, Resources…
Tom Christiansen wrote: AFAIK, modern databases are all strongly typed at least to the point that the…

RE: Re: [perl #60828] [BUG] ^@list…
On Wed, Nov 26, 2008 at 06:21:22PM -0800, Larry Wall wrote: +1 to the idea that ^@list is the same as…

RE: Files, Directories, Resources…
In-Reply-To: Message from Darren Duncan <darren@darrendunca­n.net> of "Wed, 26…

RE: Files, Directories, Resources…
In-Reply-To: Message from Mark Overmeer <mark@overmeer.net>­ of "Thu, 27 Nov…

RE: Files, Directories, Resources…
Just as a variable name in perl6 must conform to a standard and abide by a set of constraints, why…

RE: Files, Directories, Resources…
Hi, First of all, sorry for breaking the thread, but I had some trouble with my mail provider, and…
  Moderators:
 Administrator
 Protorioris

[PATCH] Apache2::RequestIO:­:read bugfix + enhancements

Torsten Foertsch 30 July 2008 20:48:14
 Hi,

it began with an innocent cycle to read the request body:

1 while( do{my $l=$r->read($conten­t, 8000, $where); $where+=$l; $l} );

Surprisingly $content was an empty string while $where said that some data was
read. I found that Apache2::RequestIO:­:read resets the passed buffer when end
of file is read that means if modperl_request_rea­d() returns 0.

Then I thought to remove these 2 XXX lines. And then what would happen in
these situations:

$content=123456;
$r->read($content, 100, 3);

or

"....."=~/(.*)/;
$r->read($1, 100);

Please review.

Torsten


-------------------­--------------------­--------------------­----------
To unsubscribe, e-mail: dev-unsubscribe@per­l.apache.org
For additional commands, e-mail: dev-help@perl.apach­e.org
Add comment
Philip M. Gollucci 18 July 2008 06:47:03 [ permanent link ]
 Torsten Foertsch wrote:
Please review.
+ /* use the same error message as perl core's read() */
+ Perl_croak(aTHX_ "Negative length");
It possible someone is regexing $@ against the previous string. Do you
really need to change the message ?


+ /* modperl_request_rea­d can return only >=0. So it's save to do
this. */
+ /* if total==0 we need to set the buffer length in case it is larger */


s/save/safe/


By any chance have you tried mod_apreq2 perl glue on top of this patch ?

+1


--
-------------------­--------------------­--------------------­-------------
Philip M. Gollucci (philip@ridecharge.­com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com­ / http://ridecharge.c­om
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Add comment
Torsten Foertsch 30 July 2008 20:48:14 [ permanent link ]
 On Fri 18 Jul 2008, Philip M. Gollucci wrote:
Torsten Foertsch wrote:
Please review.
+ /* use the same error message as perl core's read() */
+ Perl_croak(aTHX_ "Negative length");
It possible someone is regexing $@ against the previous string. Do
you really need to change the message ?

I doubt it but of course not.

+ /* modperl_request_rea­d can return only >=0. So it's save to do
this. */
+ /* if total==0 we need to set the buffer length in case it is
larger */
s/save/safe/

thanks

By any chance have you tried mod_apreq2 perl glue on top of this
patch ?

Current SVN passed all tests. So, I committed that stuff.

Torsten

--
Need professional mod_perl support?
Just hire me: torsten.foertsch@gm­x.net
Add comment
 

Add new comment

As:
Login:  Password:  
 
 
  
 
Пожалуйста, относитесь к собеседникам уважительно, не используйте нецензурные слова, не злоупотребляйте заглавными буквами, не публикуйте рекламу и объявления о купле/продаже, а также материалы нарушающие сетевой этикет или УК РФ.

QAIX > Apache HTTP Server > [PATCH] Apache2::RequestIO:­:read bugfix + enhancements 30 July 2008 20:48:14
see also:
grabbing arguments at the command line
Programming by PHP
Installing PHP in WinNT and Apache 1.3
пройди тесты:
see also:
VoIP Internet Service
RSIDLL32.DLL
Handpunch
  Copyright © 2001—2008 QAIX
Idea: Miсhael Monashev
Помощь и задать вопросы можно в сообществе support.qaix.com.
Сообщения об ошибках оставляем в сообществе bugs.qaix.com.
Предложения и комментарии пишем в сообществе suggest.qaix.com.
Информация для родителей.
Write us at:
If you would like to report an abuse of our service, such as a spam message, please .