Is it possible to delete a blog from the "I read these blogs" list?
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Hello Guest
  
  • Login
• Register…
• Start blog
  • Who, Where, When
• What can I do?
• What to Read?
  • Polls
• Avatars
• Interests
  • Cities and Countries
• Random blog
• Users search
  • Search
• Games
• Tests
• QAIX
  • Сообщества
• Talxy Chat
• Horoscope
• Online
 
Зарегистрируйся!

QAIX > Apache HTTP Server > Re: svn commit: r367475 - /perl/modperl/trunk­/lib/ModPerl/BuildMM­.pm 11 January 2006 02:11:22

  Recent blog posts: 
  Forums:   
  Discuss: 
  Recent forum topics: 
  Recent forum comments:
  Moderators:

Re: svn commit: r367475 - /perl/modperl/trunk­/lib/ModPerl/BuildMM­.pm

Philip M. Gollucci 11 January 2006 02:11:22
 Does this warrant a Changes entry ?

pgollucci@apache.or­g wrote:> Author: pgollucci> Date: Mon Jan 9 19:54:39 2006> New Revision: 367475>
Writing Makefile for X> Argument "6.30_01" isn't numeric in numeric ge (>=) at lib/ModPerl/BuildMM­.pm line 196.>
snatched from Apache2::Status>
bleed perl ~26758 includes a dev version of MakeMaker>
Modified:> perl/modperl/trunk/­lib/ModPerl/BuildMM.­pm>
Modified: perl/modperl/trunk/­lib/ModPerl/BuildMM.­pm> URL: http://svn.apache.o­rg/viewcvs/perl/modp­erl/trunk/lib/ModPer­l/BuildMM.pm?rev=367­475&r1=367474&r2=367­475&view=diff> ===================­====================­====================­===================>­ --- perl/modperl/trunk/­lib/ModPerl/BuildMM.­pm (original)> +++ perl/modperl/trunk/­lib/ModPerl/BuildMM.­pm Mon Jan 9 19:54:39 2006> @@ -193,6 +193,7 @@> # allow 'make -j'> require ExtUtils::MakeMaker­;> my $mm_ver = $ExtUtils::MakeMake­r::VERSION;> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)> ? "pm_to_blib.ts"> : "pm_to_blib";>


--
-------------------­--------------------­--------------------­-------------
"Love is not the one you can picture yourself marrying,
but the one you can't picture the rest of your life without."

"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."

"I wanna hold ya till I die ... I wanna hold ya till the fear in me
subsides."

Philip M. Gollucci (pgollucci@p6m7g8.c­om) 301.254.5198
Consultant / http://p6m7g8.net/R­esume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster­.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
Add comment
Geoffrey Young 10 January 2006 07:32:43 permanent link ]
 

Philip M. Gollucci wrote:> Does this warrant a Changes entry ?

I wouldn' think so
my $mm_ver = $ExtUtils::MakeMake­r::VERSION;>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)

isn't 'no warnings (numeric)' a bit safer than manipulating $VERSION?

--Geoff
Add comment
Philip M. Gollucci 10 January 2006 07:41:20 permanent link ]
 Geoffrey Young wrote:>
Philip M. Gollucci wrote:>> Does this warrant a Changes entry ?>
I wouldn' think so>
my $mm_ver = $ExtUtils::MakeMake­r::VERSION;>>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
Could be... Apache2::Status also does the regex.... should we swap both ?



--
-------------------­--------------------­--------------------­-------------
"Love is not the one you can picture yourself marrying,
but the one you can't picture the rest of your life without."

"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."

"I wanna hold ya till I die ... I wanna hold ya till the fear in me
subsides."

Philip M. Gollucci (pgollucci@p6m7g8.c­om) 301.254.5198
Consultant / http://p6m7g8.net/R­esume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster­.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
Add comment
Geoffrey Young 10 January 2006 16:44:03 permanent link ]
 
my $mm_ver = $ExtUtils::MakeMake­r::VERSION;>>>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01>>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)>
Could be... Apache2::Status also does the regex.... should we swap both ?

if they're both doing it then I guess that makes it ok :)­

--Geoff
Add comment
Stas Bekman 11 January 2006 02:11:22 permanent link ]
 Geoffrey Young wrote:>
Philip M. Gollucci wrote:>
Does this warrant a Changes entry ?>
I wouldn' think so>
my $mm_ver = $ExtUtils::MakeMake­r::VERSION;>>>+ $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)>
isn't 'no warnings (numeric)' a bit safer than manipulating $VERSION?

If you scope it tightly then it's probably better.

--
___________________­____________________­____________________­__
Stas Bekman mailto:stas@stason.­org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels­.com/
The "Practical mod_perl" book http://modperlbook.­org/
http://perl.apache.­org/ http://perl.org/ http://logilune.com­/
Add comment
 

Add new comment

As:
Login:  Password:  
 
 
  
 
Пожалуйста, относитесь к собеседникам уважительно, не используйте нецензурные слова, не злоупотребляйте заглавными буквами, не публикуйте рекламу и объявления о купле/продаже, а также материалы нарушающие сетевой этикет или УК РФ.


QAIX > Apache HTTP Server > Re: svn commit: r367475 - /perl/modperl/trunk­/lib/ModPerl/BuildMM­.pm 11 January 2006 02:11:22

see also:
Formatting String output
Links to randomly-accessed html pages
Text manipulation
пройди тесты:
Do you know women?
see also:
how are you, people?
And it again I! I spoke, that I shall…
Routes on Sale!

  Copyright © 2001—2008 QAIX
Idea: Miсhael Monashev
Помощь и задать вопросы можно в сообществе support.qaix.com.
Сообщения об ошибках оставляем в сообществе bugs.qaix.com.
Предложения и комментарии пишем в сообществе suggest.qaix.com.
Информация для родителей.
Write us at:
If you would like to report an abuse of our service, such as a spam message, please .